[
https://issues.apache.org/jira/browse/DRILL-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945863#comment-16945863
]
ASF GitHub Bot commented on DRILL-7385:
---------------------------------------
cgivre commented on pull request #1862: DRILL-7385: Convert PCAP Format Plugin
to EVF
URL: https://github.com/apache/drill/pull/1862#discussion_r332001328
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/store/pcap/TestPcapRecordReader.java
##########
@@ -45,8 +45,16 @@ public void testStarQuery() throws Exception {
@Test
public void testCorruptPCAPQuery() throws Exception {
runSQLVerifyCount("select * from dfs.`store/pcap/testv1.pcap`", 7000);
- runSQLVerifyCount("select * from dfs.`store/pcap/testv1.pcap` WHERE
is_corrupt=false", 6408);
- runSQLVerifyCount("select * from dfs.`store/pcap/testv1.pcap` WHERE
is_corrupt=true", 592);
+ }
+
+ @Test
+ public void testTrueCorruptPCAPQuery() throws Exception {
+ runSQLVerifyCount("select * from dfs.`store/pcap/testv1.pcap` WHERE
is_corrupt=true", 16);
+ }
+
+ @Test
+ public void testNotCorruptPCAPQuery() throws Exception {
+ runSQLVerifyCount("select * from dfs.`store/pcap/testv1.pcap` WHERE
is_corrupt=false", 6984);
Review comment:
I added new unit tests. Also, I renamed the `timestamp` column to
`packet_timestamp` so that the column name was not a Drill reserved word, which
causes issues in queries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Convert PCAP Format Plugin to EVF
> ---------------------------------
>
> Key: DRILL-7385
> URL: https://issues.apache.org/jira/browse/DRILL-7385
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.16.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 1.17.0
>
>
> The PCAP format plugin has the possibility of extracting considerably more
> data out of PCAP files. To facilitate this, this PR updates the plugin to
> use the new Enhanced Vector Framework. No changes in functionality should
> occur.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
