[
https://issues.apache.org/jira/browse/DRILL-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981569#comment-16981569
]
ASF GitHub Bot commented on DRILL-7450:
---------------------------------------
arina-ielchiieva commented on pull request #1907: DRILL-7450: Improve
performance for ANALYZE command
URL: https://github.com/apache/drill/pull/1907#discussion_r350177927
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
##########
@@ -779,7 +780,20 @@ private void allocateOutgoing(int records) {
while (outgoingIter.hasNext()) {
ValueVector vv = outgoingIter.next().getValueVector();
- AllocationHelper.allocatePrecomputedChildCount(vv, records,
maxColumnWidth, 0);
+ // Prevent allocating complex vectors here to avoid losing their content
+ // since their writers will still be used in generated code
+ switch (vv.getField().getType().getMinorType()) {
Review comment:
Maybe use `Types.isComplex` and `Types.isUnion`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve performance for ANALYZE command
> ---------------------------------------
>
> Key: DRILL-7450
> URL: https://issues.apache.org/jira/browse/DRILL-7450
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.17.0
> Reporter: Vova Vysotskyi
> Assignee: Vova Vysotskyi
> Priority: Critical
> Fix For: 1.17.0
>
>
> In the scope of DRILL-7273 was introduced ANALYZE command for collecting
> metadata and storing it to the metastore.
> But current implementation uses too much memory and is low-performant. It
> uses stream aggregate for collecting metadata, but all incoming data should
> be sorted before producing the aggregation. Memory usage may be reduced by
> using hash aggregate, so sort may not be produced and it should increase
> performance.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
