[
https://issues.apache.org/jira/browse/DRILL-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983653#comment-16983653
]
ASF GitHub Bot commented on DRILL-7450:
---------------------------------------
vvysotskyi commented on pull request #1907: DRILL-7450: Improve performance for
ANALYZE command
URL: https://github.com/apache/drill/pull/1907#discussion_r351211476
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/MetadataHashAggPOP.java
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.physical.config;
+
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.annotation.JsonTypeName;
+import org.apache.drill.exec.metastore.analyze.MetadataAggregateContext;
+import org.apache.drill.exec.physical.base.PhysicalOperator;
+import org.apache.drill.exec.planner.physical.AggPrelBase.OperatorPhase;
+import org.apache.drill.shaded.guava.com.google.common.base.Preconditions;
+
+import java.util.Collections;
+
+@JsonTypeName("metadataHashAggregate")
+public class MetadataHashAggPOP extends HashAggregate {
+ private final MetadataAggregateContext context;
+ private final OperatorPhase phase;
+
+ @JsonCreator
+ public MetadataHashAggPOP(@JsonProperty("child") PhysicalOperator child,
+ @JsonProperty("context") MetadataAggregateContext context,
+ @JsonProperty("phase") OperatorPhase phase) {
+ super(child, phase, context.groupByExpressions(), Collections.emptyList(),
1.0F);
+ this.context = context;
+ this.phase = phase;
+ Preconditions.checkArgument(context.createNewAggregations(),
Review comment:
Thanks, done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve performance for ANALYZE command
> ---------------------------------------
>
> Key: DRILL-7450
> URL: https://issues.apache.org/jira/browse/DRILL-7450
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.17.0
> Reporter: Vova Vysotskyi
> Assignee: Vova Vysotskyi
> Priority: Critical
> Fix For: 1.17.0
>
>
> In the scope of DRILL-7273 was introduced ANALYZE command for collecting
> metadata and storing it to the metastore.
> But current implementation uses too much memory and is low-performant. It
> uses stream aggregate for collecting metadata, but all incoming data should
> be sorted before producing the aggregation. Memory usage may be reduced by
> using hash aggregate, so sort may not be produced and it should increase
> performance.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
