[
https://issues.apache.org/jira/browse/DRILL-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983660#comment-16983660
]
ASF GitHub Bot commented on DRILL-7450:
---------------------------------------
vvysotskyi commented on pull request #1907: DRILL-7450: Improve performance for
ANALYZE command
URL: https://github.com/apache/drill/pull/1907#discussion_r351212890
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/DrillDistributionTrait.java
##########
@@ -180,4 +184,51 @@ public String toString() {
}
}
+ /**
+ * Stores distribution field index and field name to be used in exchange
operators.
+ * Field name is required for the case of dynamic schema discovering
+ * when field is not present in rel data type at planning time.
+ */
+ public static class NamedDistributionField extends DistributionField {
+ /**
+ * Name of the field being DISTRIBUTED.
+ */
+ private final String fieldName;
+
+ public NamedDistributionField(int fieldId, String fieldName) {
+ super(fieldId);
+ this.fieldName = fieldName;
+ }
+
+ public String getFieldName() {
+ return fieldName;
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+ if (!super.equals(o)) {
+ return false;
+ }
+
+ NamedDistributionField that = (NamedDistributionField) o;
+
+ return Objects.equals(fieldName, that.fieldName);
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(super.hashCode(), fieldName);
+ }
+
+ @Override
+ public String toString() {
+ return String.format("%s[$%s]", fieldName, super.toString());
Review comment:
Good catch, thanks, updated, so now it constructs strings like this
`dir0(1)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve performance for ANALYZE command
> ---------------------------------------
>
> Key: DRILL-7450
> URL: https://issues.apache.org/jira/browse/DRILL-7450
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.17.0
> Reporter: Vova Vysotskyi
> Assignee: Vova Vysotskyi
> Priority: Critical
> Fix For: 1.17.0
>
>
> In the scope of DRILL-7273 was introduced ANALYZE command for collecting
> metadata and storing it to the metastore.
> But current implementation uses too much memory and is low-performant. It
> uses stream aggregate for collecting metadata, but all incoming data should
> be sorted before producing the aggregation. Memory usage may be reduced by
> using hash aggregate, so sort may not be produced and it should increase
> performance.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
