[ 
https://issues.apache.org/jira/browse/DRILL-7352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004130#comment-17004130
 ] 

Igor Guzenko commented on DRILL-7352:
-------------------------------------

Since we [don't have defined 
rules|https://github.com/apache/drill/pull/1929#discussion_r361584399] for 
*switch-case* blocks, I'd suggest using rule [Switch 
statements|https://checkstyle.sourceforge.io/styleguides/google-java-style-20180523/javaguide.html#s4.8.4-switch]
 from google code style.

> Introduce new checkstyle rules to make code style more consistent
> -----------------------------------------------------------------
>
>                 Key: DRILL-7352
>                 URL: https://issues.apache.org/jira/browse/DRILL-7352
>             Project: Apache Drill
>          Issue Type: Task
>            Reporter: Vova Vysotskyi
>            Priority: Major
>
> Source - https://checkstyle.sourceforge.io/checks.html
> List of rules to be enabled:
> * [LeftCurly|https://checkstyle.sourceforge.io/config_blocks.html#LeftCurly] 
> - force placement of a left curly brace at the end of the line.
> * 
> [RightCurly|https://checkstyle.sourceforge.io/config_blocks.html#RightCurly] 
> - force placement of a right curly brace
> * 
> [NewlineAtEndOfFile|https://checkstyle.sourceforge.io/config_misc.html#NewlineAtEndOfFile]
> * 
> [UnnecessaryParentheses|https://checkstyle.sourceforge.io/config_coding.html#UnnecessaryParentheses]
> * 
> [MethodParamPad|https://checkstyle.sourceforge.io/config_whitespace.html#MethodParamPad]
> * [InnerTypeLast 
> |https://checkstyle.sourceforge.io/config_design.html#InnerTypeLast]
> * 
> [MissingOverride|https://checkstyle.sourceforge.io/config_annotation.html#MissingOverride]
> * 
> [InvalidJavadocPosition|https://checkstyle.sourceforge.io/config_javadoc.html#InvalidJavadocPosition]
> * 
> [ArrayTypeStyle|https://checkstyle.sourceforge.io/config_misc.html#ArrayTypeStyle]
> * [UpperEll|https://checkstyle.sourceforge.io/config_misc.html#UpperEll]
> and others



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to