[
https://issues.apache.org/jira/browse/DRILL-7352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17005124#comment-17005124
]
Paul Rogers commented on DRILL-7352:
------------------------------------
In prior years, we followed the Sun coding conventions, as suggested
[here|http://drill.apache.org/docs/apache-drill-contribution-guidelines/] and
documented
[here|https://www.oracle.com/technetwork/java/codeconvtoc-136057.html].
Obviously, the Sun conventions are 20 years old and do not address newer Java
features or conventions.
It is a good idea to update the Drills standards. Google's standards seem fine.
The cautious step would be to keep the original standards, adopting the Google
standards only when the don't conflict (much) with existing code.
Then, let's be sure to document the standards on the web site.
> Introduce new checkstyle rules to make code style more consistent
> -----------------------------------------------------------------
>
> Key: DRILL-7352
> URL: https://issues.apache.org/jira/browse/DRILL-7352
> Project: Apache Drill
> Issue Type: Task
> Reporter: Vova Vysotskyi
> Priority: Major
> Attachments: screenshot-1.png
>
>
> Source - https://checkstyle.sourceforge.io/checks.html
> List of rules to be enabled:
> * [LeftCurly|https://checkstyle.sourceforge.io/config_blocks.html#LeftCurly]
> - force placement of a left curly brace at the end of the line.
> *
> [RightCurly|https://checkstyle.sourceforge.io/config_blocks.html#RightCurly]
> - force placement of a right curly brace
> *
> [NewlineAtEndOfFile|https://checkstyle.sourceforge.io/config_misc.html#NewlineAtEndOfFile]
> *
> [UnnecessaryParentheses|https://checkstyle.sourceforge.io/config_coding.html#UnnecessaryParentheses]
> *
> [MethodParamPad|https://checkstyle.sourceforge.io/config_whitespace.html#MethodParamPad]
> * [InnerTypeLast
> |https://checkstyle.sourceforge.io/config_design.html#InnerTypeLast]
> *
> [MissingOverride|https://checkstyle.sourceforge.io/config_annotation.html#MissingOverride]
> *
> [InvalidJavadocPosition|https://checkstyle.sourceforge.io/config_javadoc.html#InvalidJavadocPosition]
> *
> [ArrayTypeStyle|https://checkstyle.sourceforge.io/config_misc.html#ArrayTypeStyle]
> * [UpperEll|https://checkstyle.sourceforge.io/config_misc.html#UpperEll]
> and others
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
