[
https://issues.apache.org/jira/browse/DRILL-7505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006418#comment-17006418
]
ASF GitHub Bot commented on DRILL-7505:
---------------------------------------
arina-ielchiieva commented on pull request #1946: DRILL-7505: PCAP Plugin Fails
on IPv6 Packets
URL: https://github.com/apache/drill/pull/1946#discussion_r362326297
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/decoder/PacketConstants.java
##########
@@ -40,7 +40,14 @@
public static final int FRAGMENT_V6 = 44;
public static final int AUTHENTICATION_V6 = 51;
public static final int ENCAPSULATING_SECURITY_V6 = 50;
+ public static final int ICMPv6 = 58;
public static final int MOBILITY_EXTENSION_V6 = 135;
+ public static final int HOST_IDENTITY_PROTOCOL = 139;
+ public static final int SHIM6_PROTOCOL = 140;
+
+ public static final int RESERVED_IPV6_1 = 253;
Review comment:
Please remove unused constants.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> PCAP Plugin Fails on IPv6 Packets
> ---------------------------------
>
> Key: DRILL-7505
> URL: https://issues.apache.org/jira/browse/DRILL-7505
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.17.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 1.18.0
>
>
> In its current implementation, the PCAP parser fails with an exception if it
> encounters a protocol it does not have in its enumerated list.
> This is not an acceptable strategy in that there are many protocols out there
> and having Drill crash when it encounters an unknown protocol is not helpful
> or useful. This minor PR makes the PCAP plugin more fault tolerant.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
