[ 
https://issues.apache.org/jira/browse/DRILL-7505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006519#comment-17006519
 ] 

ASF GitHub Bot commented on DRILL-7505:
---------------------------------------

cgivre commented on issue #1946: DRILL-7505: PCAP Plugin Fails on IPv6 Packets
URL: https://github.com/apache/drill/pull/1946#issuecomment-570093777
 
 
   After looking at the PCAP and PCAP-NG plugins, both of these really do need 
some work. I'm going to submit some PRs in the next few weeks for some code 
cleanup and general improvements.  This is in support of a use case at my 
company, but in general, I'd like to consolidate the PCAP and PCAP-NG plugins 
into one so that improvements don't have to be duplicated across both plugins.  
But... that's not for this PR.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> PCAP Plugin Fails on IPv6 Packets
> ---------------------------------
>
>                 Key: DRILL-7505
>                 URL: https://issues.apache.org/jira/browse/DRILL-7505
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.17.0
>            Reporter: Charles Givre
>            Assignee: Charles Givre
>            Priority: Major
>             Fix For: 1.18.0
>
>
> In its current implementation, the PCAP parser fails with an exception if it 
> encounters a protocol it does not have in its enumerated list. 
> This is not an acceptable strategy in that there are many protocols out there 
> and having Drill crash when it encounters an unknown protocol is not helpful 
> or useful.  This minor PR makes the PCAP plugin more fault tolerant.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to