[
https://issues.apache.org/jira/browse/DRILL-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031661#comment-17031661
]
ASF GitHub Bot commented on DRILL-7504:
---------------------------------------
vvysotskyi commented on pull request #1970: DRILL-7504: Upgrade Parquet library
to 1.11.0
URL: https://github.com/apache/drill/pull/1970#discussion_r375874842
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetTableMetadataUtils.java
##########
@@ -280,6 +281,12 @@ public static PartitionMetadata
getPartitionMetadata(SchemaPath partitionColumn,
return columnsStatistics;
}
+ private static boolean invalidateStatistics(MetadataBase.ColumnMetadata
column,
+ MetadataBase.ParquetTableMetadataBase tableMetadata) {
+ return column.getMinValue() == null && column.getMaxValue() == null &&
column.getNulls() == 0
Review comment:
Is this check `column.getNulls() == 0` required here? If any of the `min` or
`max` are nulls, statistics should be treated as invalid. Also, please move
other checks from the method above into this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Upgrade Parquet library to 1.11.0
> ---------------------------------
>
> Key: DRILL-7504
> URL: https://issues.apache.org/jira/browse/DRILL-7504
> Project: Apache Drill
> Issue Type: Task
> Affects Versions: 1.17.0
> Reporter: Arina Ielchiieva
> Assignee: Bohdan Kazydub
> Priority: Major
> Fix For: 1.18.0
>
>
> Upgrade Parquet library to 1.11.0
> Apache Parquet Format to 2.8.0
> Check ignored tests in:
> org.apache.drill.exec.store.parquet.TestParquetMetadataCache
> org.apache.drill.exec.store.parquet.TestPushDownAndPruningForDecimal
> org.apache.drill.exec.store.parquet.TestPushDownAndPruningForVarchar
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
