[
https://issues.apache.org/jira/browse/DRILL-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031660#comment-17031660
]
ASF GitHub Bot commented on DRILL-7504:
---------------------------------------
vvysotskyi commented on pull request #1970: DRILL-7504: Upgrade Parquet library
to 1.11.0
URL: https://github.com/apache/drill/pull/1970#discussion_r375871464
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/ConvertMetadataAggregateToDirectScanRule.java
##########
@@ -202,6 +206,23 @@ private DirectGroupScan
populateRecords(Collection<SchemaPath> interestingColumn
// populates record list with row group column metadata
for (SchemaPath schemaPath : interestingColumns) {
ColumnStatistics<?> columnStatistics =
rowGroupMetadata.getColumnsStatistics().get(schemaPath);
+ ColumnMetadata columnMetadata =
SchemaPathUtils.getColumnMetadata(schemaPath, rowGroupMetadata.getSchema());
Review comment:
Could you please move this check to the method, which will check whether any
of the schema path segments is an array.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Upgrade Parquet library to 1.11.0
> ---------------------------------
>
> Key: DRILL-7504
> URL: https://issues.apache.org/jira/browse/DRILL-7504
> Project: Apache Drill
> Issue Type: Task
> Affects Versions: 1.17.0
> Reporter: Arina Ielchiieva
> Assignee: Bohdan Kazydub
> Priority: Major
> Fix For: 1.18.0
>
>
> Upgrade Parquet library to 1.11.0
> Apache Parquet Format to 2.8.0
> Check ignored tests in:
> org.apache.drill.exec.store.parquet.TestParquetMetadataCache
> org.apache.drill.exec.store.parquet.TestPushDownAndPruningForDecimal
> org.apache.drill.exec.store.parquet.TestPushDownAndPruningForVarchar
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
