[
https://issues.apache.org/jira/browse/DRILL-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037053#comment-17037053
]
ASF GitHub Bot commented on DRILL-7583:
---------------------------------------
ihuzenko commented on pull request #1981: DRILL-7583: Remove STOP status from
operator outcome
URL: https://github.com/apache/drill/pull/1981#discussion_r379455455
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
##########
@@ -812,37 +877,43 @@ private void delayedSetup() {
* Initialize fields (that may be reused when reading spilled partitions)
*/
private void initializeBuild() {
- baseHashTable.updateIncoming(buildBatch, probeBatch); // in case we
process the spilled files
+ baseHashTable.updateIncoming(buildBatch, probeBatch); // in case we process
+ // the spilled files
// Recreate the partitions every time build is initialized
- for (int part = 0; part < numPartitions; part++ ) {
- partitions[part] = new HashPartition(context, allocator, baseHashTable,
buildBatch, probeBatch, semiJoin,
- RECORDS_PER_BATCH, spillSet, part, spilledState.getCycle(),
numPartitions);
+ for (int part = 0; part < numPartitions; part++) {
+ partitions[part] = new HashPartition(context, allocator, baseHashTable,
+ buildBatch, probeBatch, semiJoin, RECORDS_PER_BATCH, spillSet, part,
+ spilledState.getCycle(), numPartitions);
}
spilledInners = new HashJoinSpilledPartition[numPartitions];
}
/**
- * Note:
- * This method can not be called again as part of recursive call of
executeBuildPhase() to handle spilled build partitions.
+ * Note: This method can not be called again as part of recursive call of
+ * executeBuildPhase() to handle spilled build partitions.
*/
private void initializeRuntimeFilter() {
if (!enableRuntimeFilter || bloomFiltersGenerated) {
return;
}
- runtimeFilterReporter = new
RuntimeFilterReporter((ExecutorFragmentContext) context);
+ runtimeFilterReporter = new RuntimeFilterReporter(
+ (ExecutorFragmentContext) context);
Review comment:
There are a lot of new line breaks introduced in the class in situations
where the line is not actually long. Could you please revert the changes? I
would suggest considering line with length up to 100 symbols as normal. Phew...
Java is so verbal:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove STOP status in favor of fail-fast
> ----------------------------------------
>
> Key: DRILL-7583
> URL: https://issues.apache.org/jira/browse/DRILL-7583
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.17.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.18.0
>
>
> The original error solution was a complex process of a) setting a failed
> flag, b) telling all upstream operators they have failed, c) returning a
> {{STOP}} status. Drill has long supported a "fail-fast" error path based on
> throwing an exception; relying on the fragment executor to clean up the
> operator stack. Recent revisions have converted most operators to use the
> simpler fail-fast strategy based on throwing an exception instead of using
> the older {{STOP}} approach. This change simply removes the old, now-unused
> {{STOP}} based path.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
