[
https://issues.apache.org/jira/browse/DRILL-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037048#comment-17037048
]
ASF GitHub Bot commented on DRILL-7583:
---------------------------------------
ihuzenko commented on pull request #1981: DRILL-7583: Remove STOP status from
operator outcome
URL: https://github.com/apache/drill/pull/1981#discussion_r379419667
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
##########
@@ -190,35 +195,44 @@
private final JoinControl joinControl;
- // An iterator over the build side hash table (only applicable for row-key
joins)
+ // An iterator over the build side hash table (only applicable for row-key
+ // joins)
private boolean buildComplete;
// indicates if we have previously returned an output batch
private boolean firstOutputBatch = true;
private int rightHVColPosition;
private final BufferAllocator allocator;
- // Local fields for left/right incoming - may be replaced when reading from
spilled
+ // Local fields for left/right incoming - may be replaced when reading from
+ // spilled
private RecordBatch buildBatch;
private RecordBatch probeBatch;
/**
- * Flag indicating whether or not the first data holding build batch needs
to be fetched.
+ * Flag indicating whether or not the first data holding build batch needs to
+ * be fetched.
*/
private final MutableBoolean prefetchedBuild = new MutableBoolean(false);
/**
- * Flag indicating whether or not the first data holding probe batch needs
to be fetched.
+ * Flag indicating whether or not the first data holding probe batch needs to
+ * be fetched.
*/
private final MutableBoolean prefetchedProbe = new MutableBoolean(false);
// For handling spilling
private final SpillSet spillSet;
HashJoinPOP popConfig;
- private final int originalPartition = -1; // the partition a secondary reads
from
- IntVector read_right_HV_vector; // HV vector that was read from the spilled
batch
+ private final int originalPartition = -1; // the partition a secondary reads
+ // from
+ IntVector read_right_HV_vector; // HV vector that was read from the spilled
+ // batch
private final int maxBatchesInMemory;
- private final List<String> probeFields = new ArrayList<>(); // keep the same
sequence with the bloomFilters
+ private final List<String> probeFields = new ArrayList<>(); // keep the same
+ // sequence with
+ // the
+ // bloomFilters
Review comment:
Please convert such one-line comments with introduced line breaks to regular
Javadoc comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove STOP status in favor of fail-fast
> ----------------------------------------
>
> Key: DRILL-7583
> URL: https://issues.apache.org/jira/browse/DRILL-7583
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.17.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.18.0
>
>
> The original error solution was a complex process of a) setting a failed
> flag, b) telling all upstream operators they have failed, c) returning a
> {{STOP}} status. Drill has long supported a "fail-fast" error path based on
> throwing an exception; relying on the fragment executor to clean up the
> operator stack. Recent revisions have converted most operators to use the
> simpler fail-fast strategy based on throwing an exception instead of using
> the older {{STOP}} approach. This change simply removes the old, now-unused
> {{STOP}} based path.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
