[
https://issues.apache.org/jira/browse/DRILL-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037557#comment-17037557
]
ASF GitHub Bot commented on DRILL-7583:
---------------------------------------
paul-rogers commented on pull request #1981: DRILL-7583: Remove STOP status
from operator outcome
URL: https://github.com/apache/drill/pull/1981#discussion_r379847829
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
##########
@@ -308,35 +324,28 @@ public boolean hasPartitionLimit() {
*/
private final SpilledState<HashJoinSpilledPartition> spilledState = new
SpilledState<>();
private final HashJoinUpdater spilledStateUpdater = new HashJoinUpdater();
- private HashJoinSpilledPartition spilledInners[]; // for the outer to find
the partition
+ private HashJoinSpilledPartition spilledInners[]; // for the outer to find
the
+ // partition
public enum Metric implements MetricDef {
- NUM_BUCKETS,
- NUM_ENTRIES,
- NUM_RESIZING,
- RESIZING_TIME_MS,
- NUM_PARTITIONS,
- SPILLED_PARTITIONS, // number of original partitions spilled to disk
- SPILL_MB, // Number of MB of data spilled to disk. This amount is
first written,
- // then later re-read. So, disk I/O is twice this amount.
- SPILL_CYCLE, // 0 - no spill, 1 - spill, 2 - SECONDARY, 3 - TERTIARY
- LEFT_INPUT_BATCH_COUNT,
- LEFT_AVG_INPUT_BATCH_BYTES,
- LEFT_AVG_INPUT_ROW_BYTES,
- LEFT_INPUT_RECORD_COUNT,
- RIGHT_INPUT_BATCH_COUNT,
- RIGHT_AVG_INPUT_BATCH_BYTES,
- RIGHT_AVG_INPUT_ROW_BYTES,
- RIGHT_INPUT_RECORD_COUNT,
- OUTPUT_BATCH_COUNT,
- AVG_OUTPUT_BATCH_BYTES,
- AVG_OUTPUT_ROW_BYTES,
- OUTPUT_RECORD_COUNT;
+ NUM_BUCKETS, NUM_ENTRIES, NUM_RESIZING, RESIZING_TIME_MS, NUM_PARTITIONS,
+ // number of original partitions spilled to disk
+ SPILLED_PARTITIONS,
+ SPILL_MB, // Number of MB of data spilled to disk. This amount is first
+ // written,
+ // then later re-read. So, disk I/O is twice this amount.
+ SPILL_CYCLE, // 0 - no spill, 1 - spill, 2 - SECONDARY, 3 - TERTIARY
+ LEFT_INPUT_BATCH_COUNT, LEFT_AVG_INPUT_BATCH_BYTES,
LEFT_AVG_INPUT_ROW_BYTES,
+ LEFT_INPUT_RECORD_COUNT, RIGHT_INPUT_BATCH_COUNT,
RIGHT_AVG_INPUT_BATCH_BYTES,
+ RIGHT_AVG_INPUT_ROW_BYTES, RIGHT_INPUT_RECORD_COUNT, OUTPUT_BATCH_COUNT,
+ AVG_OUTPUT_BATCH_BYTES, AVG_OUTPUT_ROW_BYTES, OUTPUT_RECORD_COUNT;
Review comment:
Argh... An auto-format of a comment got loose and did the whole file. Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove STOP status in favor of fail-fast
> ----------------------------------------
>
> Key: DRILL-7583
> URL: https://issues.apache.org/jira/browse/DRILL-7583
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.17.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.18.0
>
>
> The original error solution was a complex process of a) setting a failed
> flag, b) telling all upstream operators they have failed, c) returning a
> {{STOP}} status. Drill has long supported a "fail-fast" error path based on
> throwing an exception; relying on the fragment executor to clean up the
> operator stack. Recent revisions have converted most operators to use the
> simpler fail-fast strategy based on throwing an exception instead of using
> the older {{STOP}} approach. This change simply removes the old, now-unused
> {{STOP}} based path.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
