[
https://issues.apache.org/jira/browse/DRILL-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037992#comment-17037992
]
ASF GitHub Bot commented on DRILL-7583:
---------------------------------------
paul-rogers commented on issue #1981: DRILL-7583: Remove STOP status from
operator outcome
URL: https://github.com/apache/drill/pull/1981#issuecomment-586762991
@ihuzenko, sorry for being unclear. I am suggesting that this PR focus its
functional change on removing the `STOP` status and revising the `kill()`
method. There are cosmetic changes in files visited during this work; changes
which should be low-risk and, IMHO, don't justify their own PR. (That said, we
could certainly pull out cosmetic changes to a separate PR; some reviewers
prefer that approach.)
You make good suggestions about additional refactoring and we should make
those improvements. To limit risk, I would suggest we tackle those in a
separate PR.
Does this work for you? Anything else that I should fix in this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove STOP status in favor of fail-fast
> ----------------------------------------
>
> Key: DRILL-7583
> URL: https://issues.apache.org/jira/browse/DRILL-7583
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.17.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.18.0
>
>
> The original error solution was a complex process of a) setting a failed
> flag, b) telling all upstream operators they have failed, c) returning a
> {{STOP}} status. Drill has long supported a "fail-fast" error path based on
> throwing an exception; relying on the fragment executor to clean up the
> operator stack. Recent revisions have converted most operators to use the
> simpler fail-fast strategy based on throwing an exception instead of using
> the older {{STOP}} approach. This change simply removes the old, now-unused
> {{STOP}} based path.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
