[
https://issues.apache.org/jira/browse/DRILL-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040792#comment-17040792
]
ASF GitHub Bot commented on DRILL-7590:
---------------------------------------
vvysotskyi commented on issue #1988: DRILL-7590: Refactor plugin registry
URL: https://github.com/apache/drill/pull/1988#issuecomment-588841695
The problem is that not all contributors run full tests suite before opening
the pull request or rerunning it after making some changes. So if we will
exclude some tests from GitHub Actions, we would increase cases when some
failing tests were found only when doing batch commits, so batch committer
would have to find PR which caused the failures, point contributor to the
failing test and after that reviewer should do the review again.
I like the approach of running focused unit tests for narrowing down the
problem, and as you pointed, it may be reached by using existing unit tests
categories. I think we should at least document in contribution guide that the
way how slow and unlikely tests may be excluded from the tests run in the case
of issues to find a simpler test to reproduce the issue.
```
mvn test
-DexcludedGroups="org.apache.drill.categories.SlowTest,org.apache.drill.categories.UnlikelyTest,org.apache.drill.categories.SecurityTest"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor plugin registry
> ------------------------
>
> Key: DRILL-7590
> URL: https://issues.apache.org/jira/browse/DRILL-7590
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.17.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.18.0
>
>
> The plugin registry connects configurations, stored in ZK, with
> implementations, which are Java classes. The registry handles a large number
> of tasks including:
> * Populating "bootstrap" plugin configurations and handling upgrades.
> * Reading from, and writing to, the persistent store in ZK.
> * Handling "normal" (configured) plugins and special system plugins (which
> have no configuration.)
> * Handle format plugins which are always associated with the DFS storage
> plugin.
> * And so on.
> The code has grown overly complex. As we look to add a new, cleaner plugin
> mechanism, we will start by cleaning up what we have to allow the new
> mechanism to be one of many.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
