[
https://issues.apache.org/jira/browse/DRILL-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17041240#comment-17041240
]
ASF GitHub Bot commented on DRILL-7590:
---------------------------------------
paul-rogers commented on issue #1988: DRILL-7590: Refactor plugin registry
URL: https://github.com/apache/drill/pull/1988#issuecomment-589255074
@vvysotskyi, the ideal solution is to make the full "pre-commit" test suite
available to committers. That way, for example, I could help with the commit
process as I used to do when at MapR. The workflow would then be:
1. Ideally, run the full unit tests on the dev machine. Or, at least unit
tests around the fix.
2. A "smoke test" run on GitHub when pushing the branch.
3. PR and code review.
4. The full "pre-commit" run by a committer.
5. Commit.
Drill used to do batch commits on Friday. This meant that some engineer had
to do the merges and run the pre-commit tests. Took time. In Impala, we each
ran the equivalent of the pre-commit tests and merged our own patches after
approval. Since this could be done offline (run in the evening, say), it was
not as much of a time sink as the old Drill process.
I suppose there are two questions. 1) Do you (or someone on the team)
understand the current system well enough to set up a duplicate on, say, AWS?
and, of course, 2) Where do we get funding for the AWS (or GCE) instance?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor plugin registry
> ------------------------
>
> Key: DRILL-7590
> URL: https://issues.apache.org/jira/browse/DRILL-7590
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.17.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.18.0
>
>
> The plugin registry connects configurations, stored in ZK, with
> implementations, which are Java classes. The registry handles a large number
> of tasks including:
> * Populating "bootstrap" plugin configurations and handling upgrades.
> * Reading from, and writing to, the persistent store in ZK.
> * Handling "normal" (configured) plugins and special system plugins (which
> have no configuration.)
> * Handle format plugins which are always associated with the DFS storage
> plugin.
> * And so on.
> The code has grown overly complex. As we look to add a new, cleaner plugin
> mechanism, we will start by cleaning up what we have to allow the new
> mechanism to be one of many.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
