[
https://issues.apache.org/jira/browse/DRILL-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17045414#comment-17045414
]
ASF GitHub Bot commented on DRILL-7590:
---------------------------------------
arina-ielchiieva commented on pull request #1988: DRILL-7590: Refactor plugin
registry
URL: https://github.com/apache/drill/pull/1988#discussion_r383960485
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
##########
@@ -43,36 +43,32 @@
import java.util.stream.StreamSupport;
/**
- * <p> {@link OptionManager} that holds options within {@link
org.apache.drill.exec.server.DrillbitContext}.
+ * <p>{@link OptionManager} that holds options within {@link
org.apache.drill.exec.server.DrillbitContext}.
* Only one instance of this class exists per drillbit. Options set at the
system level affect the entire system and
* persist between restarts.
- * </p>
- *
- * <p> All the system options are externalized into conf file. While adding a
new system option
- * a validator should be added and the default value for the option should be
set in
- * the conf files(example : drill-module.conf) under the namespace
drill.exec.options.
- * </p>
- *
- * <p>
- * The SystemOptionManager loads all the validators and the default values
for the options are
- * fetched from the config. The validators are populated with the default
values fetched from
- * the config. If the option is not set in the conf files config option is
missing exception
- * will be thrown.
- * </p>
- *
- * <p>
- * If the option is set using ALTER, the value that is set will be returned.
Else the default value
- * that is loaded into validator from the config will be returned.
- * </p>
+ * </p><p>
+ * All the system options are externalized into conf file. While adding a new
system option
+ * a validator should be added and the default value for the option should be
set in
+ * the conf files(example : drill-module.conf) under the namespace
drill.exec.options.
+ * </p><p>
+ * The SystemOptionManager loads all the validators and the default values for
the options are
+ * fetched from the config. The validators are populated with the default
values fetched from
+ * the config. If the option is not set in the conf files config option is
missing exception
+ * will be thrown.
+ * </p><p>
+ If the option is set using ALTER, the value that is set will be returned.
Else the default value
+ * that is loaded into validator from the config will be returned.
+ * </p>
*/
public class SystemOptionManager extends BaseOptionManager implements
AutoCloseable {
private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(SystemOptionManager.class);
Review comment:
Please fix logger since you are making changes in this class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor plugin registry
> ------------------------
>
> Key: DRILL-7590
> URL: https://issues.apache.org/jira/browse/DRILL-7590
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.17.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.18.0
>
>
> The plugin registry connects configurations, stored in ZK, with
> implementations, which are Java classes. The registry handles a large number
> of tasks including:
> * Populating "bootstrap" plugin configurations and handling upgrades.
> * Reading from, and writing to, the persistent store in ZK.
> * Handling "normal" (configured) plugins and special system plugins (which
> have no configuration.)
> * Handle format plugins which are always associated with the DFS storage
> plugin.
> * And so on.
> The code has grown overly complex. As we look to add a new, cleaner plugin
> mechanism, we will start by cleaning up what we have to allow the new
> mechanism to be one of many.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
