[
https://issues.apache.org/jira/browse/DRILL-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17045424#comment-17045424
]
ASF GitHub Bot commented on DRILL-7590:
---------------------------------------
arina-ielchiieva commented on pull request #1988: DRILL-7590: Refactor plugin
registry
URL: https://github.com/apache/drill/pull/1988#discussion_r383982716
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/PluginBootstrapLoader.java
##########
@@ -17,6 +17,22 @@
*/
package org.apache.drill.exec.store;
-public interface DistributedStorageEngine {
- public String getDfsName();
+import java.io.IOException;
+
+import org.apache.drill.exec.planner.logical.StoragePlugins;
+
+/**
+ * Generalized interface for bootstraping or upgrading the plugin persistent
+ * store. Provides the list of bootstrap plugins, along with those to be
+ * upgraded. Provides confirmation that the upgrade was performed to avoid
+ * doing it again.
+ * <p>
+ * <b>Caveats:</b>: The upgrade mechanism is rather ad-hoc; it actually needs
+ * a version number to be solid, but the persistent store does not currently
+ * provide a version number.
+ */
+public interface PluginBootstrapLoader {
+ StoragePlugins bootstrapPlugins() throws IOException;
+ StoragePlugins updatedPlugins();
+ void onUpgrade();
Review comment:
Please add java doc for this method in particular, since it's not clear what
it does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor plugin registry
> ------------------------
>
> Key: DRILL-7590
> URL: https://issues.apache.org/jira/browse/DRILL-7590
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.17.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.18.0
>
>
> The plugin registry connects configurations, stored in ZK, with
> implementations, which are Java classes. The registry handles a large number
> of tasks including:
> * Populating "bootstrap" plugin configurations and handling upgrades.
> * Reading from, and writing to, the persistent store in ZK.
> * Handling "normal" (configured) plugins and special system plugins (which
> have no configuration.)
> * Handle format plugins which are always associated with the DFS storage
> plugin.
> * And so on.
> The code has grown overly complex. As we look to add a new, cleaner plugin
> mechanism, we will start by cleaning up what we have to allow the new
> mechanism to be one of many.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
