[
https://issues.apache.org/jira/browse/DRILL-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056381#comment-17056381
]
ASF GitHub Bot commented on DRILL-7437:
---------------------------------------
paul-rogers commented on pull request #1892: DRILL-7437: Storage Plugin for
Generic HTTP REST API
URL: https://github.com/apache/drill/pull/1892#discussion_r390585371
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java
##########
@@ -253,11 +268,20 @@ private void updateRunningCount() {
runningRecordCount += recordCount;
}
+ public void setInputStream(InputStream in) {
+ this.inputStream = in;
+ }
+
@Override
public void close() throws Exception {
if (stream != null) {
stream.close();
stream = null;
}
+
+ if (inputStream != null) {
+ inputStream.close();
+ inputStream = null;
+ }
Review comment:
Doesn't the Jackson parser close the input stream when the parser itself is
closed? At least, that is what I thought I found in my own JSON tests. If not,
we've got a pile of open HDFS streams that we've never closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Storage Plugin for Generic HTTP REST API
> ----------------------------------------
>
> Key: DRILL-7437
> URL: https://issues.apache.org/jira/browse/DRILL-7437
> Project: Apache Drill
> Issue Type: New Feature
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Minor
> Fix For: Future
>
>
> In many data analytic situations there is a need to obtain reference data
> which is volatile or hosted on a service with a REST API.
> For instance, consider the case of a financial dataset which you want to run
> a currency conversion. Or in the security arena, an organization might have
> a service that returns network information about an IT asset. The goal being
> to enable Drill to quickly incorporate external data that is only accessible
> via REST API.
> This plugin is not intended to be a substitute for dedicated storage plugins
> with systems that use a REST API, such as Apache Solr or ElasticSearch.
> This plugin is based on several projects that were posted on github but never
> completed or submitted to Drill. Posted here for attribution:
> * [https://github.com/kevinlynx/drill-storage-http]
> * [https://github.com/mayunSaicmotor/drill-storage-http]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
