[
https://issues.apache.org/jira/browse/DRILL-7330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059856#comment-17059856
]
ASF GitHub Bot commented on DRILL-7330:
---------------------------------------
vvysotskyi commented on pull request #2026: DRILL-7330: Implement metadata
usage for all format plugins
URL: https://github.com/apache/drill/pull/2026#discussion_r392683321
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/file/FileMetadataColumn.java
##########
@@ -65,6 +82,11 @@ public FileMetadataColumn(String name,
FileMetadataColumnDefn defn) {
@Override
public MetadataColumn resolve(FileMetadata fileInfo, VectorSource source,
int sourceIndex) {
- return new FileMetadataColumn(name(), defn, fileInfo, source, sourceIndex);
+ if (value() == null) {
+ return new FileMetadataColumn(name(), defn, fileInfo, source,
sourceIndex);
+ } else {
+ // case of metadata column, which should have null value independently
of its column definition
+ return new FileMetadataColumn(name(), defn, (String) null, source,
sourceIndex);
Review comment:
This change is required only for the case when we need to enforce the value
of the implicit column to `null` before it is written to the vector.
I have reworked changes in the `ReaderSchemaOrchestrator`, so this one is
not required anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Implement metadata usage for text format plugin
> -----------------------------------------------
>
> Key: DRILL-7330
> URL: https://issues.apache.org/jira/browse/DRILL-7330
> Project: Apache Drill
> Issue Type: Sub-task
> Reporter: Arina Ielchiieva
> Assignee: Vova Vysotskyi
> Priority: Major
> Fix For: 1.18.0
>
>
> 1. Change the current group scan to leverage Schema from Metastore;
> 2. Use stats for enabling additional logical planning rules for text format
> plugin. It will enable such optimizations as limit, filter push and so on.
> + add possibility to pass schema through schema file (using path or table
> root), inline.
> + check for other enhancements in analyze command
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
