[ https://issues.apache.org/jira/browse/DRILL-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071216#comment-17071216 ]
ASF GitHub Bot commented on DRILL-7668: --------------------------------------- vvysotskyi commented on issue #2040: DRILL-7668: Allow Time Bucket Function to Accept Floats and Timestamps URL: https://github.com/apache/drill/pull/2040#issuecomment-606196720 @cgivre, this pull request introduces unit tests failure: ``` [ERROR] org.apache.drill.exec.udfs.TestTimeBucketFunction.testTimeBucketTimestamp Time elapsed: 2.584 s <<< ERROR! java.lang.Exception: at position 0 column '`high`' mismatched values, expected: 2020-03-27T01:30(LocalDateTime) but received 2020-03-26T18:30(LocalDateTime) Expected Records near verification failure: Record Number: 0 { `high` : 2020-03-27T01:30, } Actual Records near verification failure: Record Number: 0 { `high` : 2020-03-26T18:30, } For query: SELECT time_bucket(CAST(1585272833845 AS TIMESTAMP), 300000) AS high FROM (values(1)) at org.apache.drill.exec.udfs.TestTimeBucketFunction.testTimeBucketTimestamp(TestTimeBucketFunction.java:116) Caused by: java.lang.Exception: at position 0 column '`high`' mismatched values, expected: 2020-03-27T01:30(LocalDateTime) but received 2020-03-26T18:30(LocalDateTime) Expected Records near verification failure: Record Number: 0 { `high` : 2020-03-27T01:30, } Actual Records near verification failure: Record Number: 0 { `high` : 2020-03-26T18:30, } at org.apache.drill.exec.udfs.TestTimeBucketFunction.testTimeBucketTimestamp(TestTimeBucketFunction.java:116) Caused by: java.lang.Exception: at position 0 column '`high`' mismatched values, expected: 2020-03-27T01:30(LocalDateTime) but received 2020-03-26T18:30(LocalDateTime) at org.apache.drill.exec.udfs.TestTimeBucketFunction.testTimeBucketTimestamp(TestTimeBucketFunction.java:116) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow Time Bucket Function to Accept Floats and Timestamps > ---------------------------------------------------------- > > Key: DRILL-7668 > URL: https://issues.apache.org/jira/browse/DRILL-7668 > Project: Apache Drill > Issue Type: Improvement > Components: Functions - Drill > Affects Versions: 1.18.0 > Reporter: Charles Givre > Assignee: Charles Givre > Priority: Minor > Labels: ready-to-commit > Fix For: 1.18.0 > > > Drill has a function `time_bucket()` which facilitates time series analysis. > This PR extends this function to accept `FLOAT8` and `TIMESTAMPS` as input. > Floats are typically not used for timestamps, however in the event that the > data is coming from imperfect files, the numbers may be read as floats and > hence require casting in queries. This PR makes this easier. -- This message was sent by Atlassian Jira (v8.3.4#803005)