[
https://issues.apache.org/jira/browse/DRILL-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17075994#comment-17075994
]
ASF GitHub Bot commented on DRILL-7668:
---------------------------------------
cgivre commented on pull request #2040: DRILL-7668: Allow Time Bucket Function
to Accept Floats and Timestamps
URL: https://github.com/apache/drill/pull/2040#discussion_r403792155
##########
File path:
contrib/udfs/src/test/java/org/apache/drill/exec/udfs/TestTimeBucketFunction.java
##########
@@ -92,6 +94,28 @@ public void testTimeBucket() throws Exception {
.go();
}
+ @Test
+ public void testDoubleTimeBucket() throws Exception {
+ String query = "SELECT time_bucket(CAST(1451606760 AS DOUBLE), 300000) AS
high FROM (values(1))";
+ testBuilder()
+ .sqlQuery(query)
+ .ordered()
+ .baselineColumns("high")
+ .baselineValues(1451400000L)
+ .go();
+ }
+
+ @Test
+ public void testTimeBucketTimestamp() throws Exception {
+ String query = "SELECT time_bucket(CAST(1585272833845 AS TIMESTAMP),
300000) AS high FROM (values(1))";
Review comment:
Removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Allow Time Bucket Function to Accept Floats and Timestamps
> ----------------------------------------------------------
>
> Key: DRILL-7668
> URL: https://issues.apache.org/jira/browse/DRILL-7668
> Project: Apache Drill
> Issue Type: Improvement
> Components: Functions - Drill
> Affects Versions: 1.18.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Minor
> Labels: ready-to-commit
> Fix For: 1.18.0
>
>
> Drill has a function `time_bucket()` which facilitates time series analysis.
> This PR extends this function to accept `FLOAT8` and `TIMESTAMPS` as input.
> Floats are typically not used for timestamps, however in the event that the
> data is coming from imperfect files, the numbers may be read as floats and
> hence require casting in queries. This PR makes this easier.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
