[
https://issues.apache.org/jira/browse/DRILL-7729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099469#comment-17099469
]
ASF GitHub Bot commented on DRILL-7729:
---------------------------------------
paul-rogers opened a new pull request #2076:
URL: https://github.com/apache/drill/pull/2076
# [DRILL-7729](https://issues.apache.org/jira/browse/DRILL-7729): Use
java.time in column accessors
(Please replace `PR Title` with actual PR Title)
## Description
Uses` java.time` classes in the column accessors. Leaves Joda time for
`Interval`, as it has no `java.time` equivalent.
This change allows the column accessors to work with Drill's JSON writer
implementation. This PR includes a new `JsonWriter` based on a `RowSetReader`.
## Documentation
The change is transparent to users **except** in one particular case: a use
of the "provided schema" feature in which the user has provided a format for a
`DATE`, `TIME` or `TIMESTAMP` column. The `java.time` formats are slightly
different than their Joda predecessors.
## Testing
Modified all tests which used Joda formats. Reran the full unit test suite.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use java.time in column accessors
> ---------------------------------
>
> Key: DRILL-7729
> URL: https://issues.apache.org/jira/browse/DRILL-7729
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.17.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.18.0
>
>
> Use {{java.time}} classes in the column accessors, except for {{Interval}},
> which has no {{java.time}} equivalent. Doing so allows us to create a row-set
> version of Drill's JSON writer.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
