[
https://issues.apache.org/jira/browse/DRILL-7729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102184#comment-17102184
]
ASF GitHub Bot commented on DRILL-7729:
---------------------------------------
cgivre commented on a change in pull request #2076:
URL: https://github.com/apache/drill/pull/2076#discussion_r421900398
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/vector/DateUtilities.java
##########
@@ -195,7 +197,27 @@ public static int timeToMillis(int hours, int minutes, int
seconds, int millis)
* @param localTime Java local time
* @return Drill form of the time
Review comment:
@paul-rogers
Would you mind please adding a brief javadoc to this class explaining what a
Drill form of the time is?
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/convert/StandardConversions.java
##########
@@ -166,6 +171,12 @@ public static DirectConverter newInstance(
try {
final Constructor<? extends DirectConverter> ctor =
conversionClass.getDeclaredConstructor(ScalarWriter.class, Map.class);
return ctor.newInstance(baseWriter, properties);
+ } catch (final InvocationTargetException e) {
+ throw UserException.validationError(e.getTargetException())
+ .addContext("Converter setup failed")
+ .addContext("Conversion class" + conversionClass.getName())
+ // .addContext(errorContext) // Add after merge
Review comment:
Should we add this line back in?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Use java.time in column accessors
> ---------------------------------
>
> Key: DRILL-7729
> URL: https://issues.apache.org/jira/browse/DRILL-7729
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.17.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.18.0
>
>
> Use {{java.time}} classes in the column accessors, except for {{Interval}},
> which has no {{java.time}} equivalent. Doing so allows us to create a row-set
> version of Drill's JSON writer.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
