[
https://issues.apache.org/jira/browse/DRILL-8017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17432637#comment-17432637
]
ASF GitHub Bot commented on DRILL-8017:
---------------------------------------
cgivre commented on a change in pull request #2344:
URL: https://github.com/apache/drill/pull/2344#discussion_r733909393
##########
File path:
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/MapRDBFormatPluginConfig.java
##########
@@ -53,6 +53,30 @@ public int hashCode() {
return result;
}
+ @Override
+ public boolean equals(Object obj) {
Review comment:
I'm hesitant to mess with this too much. Lombok does both and this
function already had a `hashcode` function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix LGTM Issues Relating to Equals and HashCode Functions
> ---------------------------------------------------------
>
> Key: DRILL-8017
> URL: https://issues.apache.org/jira/browse/DRILL-8017
> Project: Apache Drill
> Issue Type: Improvement
> Components: Security
> Affects Versions: 1.19.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Minor
> Fix For: 1.20.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
