[
https://issues.apache.org/jira/browse/DRILL-8017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433903#comment-17433903
]
ASF GitHub Bot commented on DRILL-8017:
---------------------------------------
vdiravka commented on a change in pull request #2344:
URL: https://github.com/apache/drill/pull/2344#discussion_r735818102
##########
File path:
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/TableFormatPluginConfig.java
##########
@@ -20,7 +20,7 @@
import org.apache.drill.common.logical.FormatPluginConfig;
public abstract class TableFormatPluginConfig implements FormatPluginConfig {
-
+ //lgtm [java/inconsistent-equals-and-hashcode]
Review comment:
Is this eliminate this part of code from LGTM code analyzing? Or it is
just a note/todo?
##########
File path:
logical/src/main/java/org/apache/drill/common/logical/data/LogicalOperatorBase.java
##########
@@ -40,6 +40,11 @@ public final int hashCode() {
return super.hashCode();
Review comment:
Could you add the space please after `implements LogicalOperator` on the
32 line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix LGTM Issues Relating to Equals and HashCode Functions
> ---------------------------------------------------------
>
> Key: DRILL-8017
> URL: https://issues.apache.org/jira/browse/DRILL-8017
> Project: Apache Drill
> Issue Type: Improvement
> Components: Security
> Affects Versions: 1.19.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Minor
> Fix For: 1.20.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
