[
https://issues.apache.org/jira/browse/DRILL-8057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472078#comment-17472078
]
ASF GitHub Bot commented on DRILL-8057:
---------------------------------------
vvysotskyi commented on a change in pull request #2388:
URL: https://github.com/apache/drill/pull/2388#discussion_r781256339
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/SchemaTreeProvider.java
##########
@@ -154,17 +156,23 @@ public SchemaPlus createFullRootSchema(SchemaConfig
schemaConfig) {
.build(logger);
}
}
+ */
@Override
public void close() throws Exception {
+ //TODO jnturton: clean up
+ /*
List<AutoCloseable> toClose = Lists.newArrayList();
for(SchemaPlus tree : schemaTreesToClose) {
addSchemasToCloseList(tree, toClose);
}
AutoCloseables.close(toClose);
+ */
}
+ //TODO jnturton: clean up
+ /*
private static void addSchemasToCloseList(final SchemaPlus tree, final
List<AutoCloseable> toClose) {
for(String subSchemaName : tree.getSubSchemaNames()) {
addSchemasToCloseList(tree.getSubSchema(subSchemaName), toClose);
Review comment:
Yes, initially I had doubts about this change, but for now, I propose to
delete this method. For the case when someone would need to add some special
logic under it, this change might be reconsidered. But we should be sure that
changes in this PR are covered by tests, so breaking this optimization would be
easily detected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> INFORMATION_SCHEMA filter push down is inefficient
> --------------------------------------------------
>
> Key: DRILL-8057
> URL: https://issues.apache.org/jira/browse/DRILL-8057
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Information Schema
> Affects Versions: 1.19.0
> Reporter: James Turton
> Assignee: James Turton
> Priority: Major
> Fix For: 1.20.0
>
>
> WHERE clauses in queries against INFORMATION_SCHEMA do not stop Drill from
> fetching a schema hierarchy from all enabled storage configs. This results
> in abysmal performance when unresponsive data sources are enabled, as
> reported by users in the Apache Drill Slack channels.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
