[
https://issues.apache.org/jira/browse/DRILL-8057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476246#comment-17476246
]
ASF GitHub Bot commented on DRILL-8057:
---------------------------------------
jnturton commented on a change in pull request #2388:
URL: https://github.com/apache/drill/pull/2388#discussion_r784968419
##########
File path:
exec/java-exec/src/main/java/org/apache/calcite/jdbc/DynamicRootSchema.java
##########
@@ -150,6 +150,11 @@ public String getTypeName() {
DataContext.ROOT,
BuiltInMethod.DATA_CONTEXT_GET_ROOT_SCHEMA.method);
}
+
+ @Override
+ public boolean showInInformationSchema() {
+ return false;
+ }
}
Review comment:
@cgivre here's the description on this method in AbstractSchema. I
believe it was added when the information_schema db was originally developed.
```
/**
* Reports whether to show items from this schema in INFORMATION_SCHEMA
* tables.
* (Controls ... TODO: Doc.: Mention what this typically controls or
* affects.)
* <p>
* This base implementation returns {@code true}.
* </p>
*/
public boolean showInInformationSchema() {
return true;
}
```
The override in this PR says "don't show the root schema in query results
against information_schema".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> INFORMATION_SCHEMA filter push down is inefficient
> --------------------------------------------------
>
> Key: DRILL-8057
> URL: https://issues.apache.org/jira/browse/DRILL-8057
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Information Schema
> Affects Versions: 1.19.0
> Reporter: James Turton
> Assignee: James Turton
> Priority: Major
> Fix For: 1.20.0
>
>
> WHERE clauses in queries against INFORMATION_SCHEMA do not stop Drill from
> fetching a schema hierarchy from all enabled storage configs. This results
> in abysmal performance when unresponsive data sources are enabled, as
> reported by users in the Apache Drill Slack channels.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
