[
https://issues.apache.org/jira/browse/DRILL-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552588#comment-17552588
]
ASF GitHub Bot commented on DRILL-8244:
---------------------------------------
vdiravka commented on code in PR #2571:
URL: https://github.com/apache/drill/pull/2571#discussion_r893211946
##########
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java:
##########
@@ -153,10 +149,15 @@ public void setup() {
drillbitContext,
pluginName
);
+
endpointConfig =
org.apache.drill.exec.store.http.util.SimpleHttp.getEndpointConfig(
endpointName,
plugin.getConfig()
);
+
+ // Add JSON configuration from Storage plugin, if present.
+ jsonLoaderBuilder =
org.apache.drill.exec.store.http.udfs.HttpUdfUtils.setupJsonBuilder(endpointConfig,
loader, options);
Review Comment:
> There was a bunch of logic that was getting difficult to do with all the
full paths, and it was really hard to debug.
Do you mean full path of classes (without imports)?
> HTTP_Request Not Passing Down Config Variable
> ---------------------------------------------
>
> Key: DRILL-8244
> URL: https://issues.apache.org/jira/browse/DRILL-8244
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - Other
> Affects Versions: 1.20.1
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 2.0.0
>
>
> The http_request UDF was not passing down the provided schema and other
> config parameters down to the jsonLoader.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
