[ 
https://issues.apache.org/jira/browse/DRILL-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552591#comment-17552591
 ] 

ASF GitHub Bot commented on DRILL-8244:
---------------------------------------

vdiravka commented on code in PR #2571:
URL: https://github.com/apache/drill/pull/2571#discussion_r894210913


##########
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java:
##########
@@ -153,10 +149,15 @@ public void setup() {
         drillbitContext,
         pluginName
       );
+
       endpointConfig = 
org.apache.drill.exec.store.http.util.SimpleHttp.getEndpointConfig(
         endpointName,
         plugin.getConfig()
       );
+
+      // Add JSON configuration from Storage plugin, if present.
+      jsonLoaderBuilder = 
org.apache.drill.exec.store.http.udfs.HttpUdfUtils.setupJsonBuilder(endpointConfig,
 loader, options);

Review Comment:
   It can be easly debug after uncommenting this 
[saveCode](https://github.com/apache/drill/blob/570ce63088ab4e2b479b53a9b41696adbb0c9278/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java#L303)
 line of code in `ProjectRecordBatch`.
   You can find more info in 
[GeneratedCode.md](https://github.com/apache/drill/blob/dc8d0107cb6a4a31e1beaa9c98d6e51cf7486a67/docs/dev/GeneratedCode.md#instructions-for-intellij)
 doc





> HTTP_Request Not Passing Down Config Variable
> ---------------------------------------------
>
>                 Key: DRILL-8244
>                 URL: https://issues.apache.org/jira/browse/DRILL-8244
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Storage - Other
>    Affects Versions: 1.20.1
>            Reporter: Charles Givre
>            Assignee: Charles Givre
>            Priority: Major
>             Fix For: 2.0.0
>
>
> The http_request UDF was not passing down the provided schema and other 
> config parameters down to the jsonLoader.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to