[ https://issues.apache.org/jira/browse/DRILL-8430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721260#comment-17721260 ]
ASF GitHub Bot commented on DRILL-8430: --------------------------------------- pjfanning commented on code in PR #2800: URL: https://github.com/apache/drill/pull/2800#discussion_r1189568415 ########## exec/java-exec/src/main/java/org/apache/drill/exec/store/http/oauth/OAuthUtils.java: ########## @@ -36,6 +37,7 @@ public class OAuthUtils { private static final Logger logger = LoggerFactory.getLogger(OAuthUtils.class); + private static final ObjectMapper MAPPER = JacksonUtils.createObjectMapper(); Review Comment: the problem with global object mappers, writers and readers is that if they are public, then someone can modify their config - exactly the issue I found in our test code I opened https://issues.apache.org/jira/browse/DRILL-8431 to look at wrapping the Jackson classes to create immutable instances that can be more safely shared. So far, that looks like a lot of work and the benefits may not be worth it. > add factory method for creating Jackson ObjectMappers > ----------------------------------------------------- > > Key: DRILL-8430 > URL: https://issues.apache.org/jira/browse/DRILL-8430 > Project: Apache Drill > Issue Type: Task > Components: Server > Reporter: PJ Fanning > Priority: Major > > See https://issues.apache.org/jira/browse/DRILL-8415 > It's useful to keep any customisation of the ObjectMapper creation in 1 placeĀ -- This message was sent by Atlassian Jira (v8.20.10#820010)