[
https://issues.apache.org/jira/browse/DRILL-8430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721262#comment-17721262
]
ASF GitHub Bot commented on DRILL-8430:
---------------------------------------
jnturton commented on code in PR #2800:
URL: https://github.com/apache/drill/pull/2800#discussion_r1189578197
##########
exec/java-exec/src/main/java/org/apache/drill/exec/store/http/oauth/OAuthUtils.java:
##########
@@ -36,6 +37,7 @@
public class OAuthUtils {
private static final Logger logger =
LoggerFactory.getLogger(OAuthUtils.class);
+ private static final ObjectMapper MAPPER = JacksonUtils.createObjectMapper();
Review Comment:
Hmm, reading [on little](https://stackoverflow.com/a/36162525/1153953)
reveals that lock contention in a shared ObjectMapper degrades performance for
multithreaded applications . Now I'm in two minds.
##########
exec/java-exec/src/main/java/org/apache/drill/exec/store/http/oauth/OAuthUtils.java:
##########
@@ -36,6 +37,7 @@
public class OAuthUtils {
private static final Logger logger =
LoggerFactory.getLogger(OAuthUtils.class);
+ private static final ObjectMapper MAPPER = JacksonUtils.createObjectMapper();
Review Comment:
Hmm, reading [on a little](https://stackoverflow.com/a/36162525/1153953)
reveals that lock contention in a shared ObjectMapper degrades performance for
multithreaded applications . Now I'm in two minds.
> add factory method for creating Jackson ObjectMappers
> -----------------------------------------------------
>
> Key: DRILL-8430
> URL: https://issues.apache.org/jira/browse/DRILL-8430
> Project: Apache Drill
> Issue Type: Task
> Components: Server
> Reporter: PJ Fanning
> Priority: Major
>
> See https://issues.apache.org/jira/browse/DRILL-8415
> It's useful to keep any customisation of the ObjectMapper creation in 1 place
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
