[ https://issues.apache.org/jira/browse/DRILL-8474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803367#comment-17803367 ]
ASF GitHub Bot commented on DRILL-8474: --------------------------------------- cgivre commented on PR #2836: URL: https://github.com/apache/drill/pull/2836#issuecomment-1877962587 @mbeckerle I had a thought about your TODO list. See inline. > This is ready for a next review. All the scalar types are now implemented with typed setter calls. > > The prior review comments have all been addressed I believe. > > Remaining things to do include: > > 1. How to get the compiled DFDL schema object so it can be loaded by daffodil out at the distributed Drill nodes. I was thinking about this and I remembered something that might be useful. Drill has support for User Defined Functions (UDF) which are written in Java. To add a UDF to Drill, you also have to write some Java classes in a particular way, and include the JARs. Much like the DFDL class files, the UDF JARs must be accessible to all nodes of a Drill cluster. Additionally, Drill has the capability of adding UDFs dynamically. This feature was added here: https://github.com/apache/drill/pull/574. Anyway, I wonder if we could use a similar mechanism to load and store the DFDL files so that they are accessible to all Drill nodes. What do you think? > 2. Test of nilled values (and more tests generally to show deeply nested and repeating nested objects work.) > 3. Errors - revisit every place errors are detected or thrown to make sure these are being done the right way for DFDL schema compilation and runtime errors as well. > Add Daffodil Format Plugin > -------------------------- > > Key: DRILL-8474 > URL: https://issues.apache.org/jira/browse/DRILL-8474 > Project: Apache Drill > Issue Type: New Feature > Affects Versions: 1.21.1 > Reporter: Charles Givre > Priority: Major > Fix For: 1.22.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)