[
https://issues.apache.org/jira/browse/DRILL-8474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803983#comment-17803983
]
ASF GitHub Bot commented on DRILL-8474:
---------------------------------------
cgivre commented on PR #2836:
URL: https://github.com/apache/drill/pull/2836#issuecomment-1880109717
@mbeckerle
With respect to style, I tried to reply to that comment, but the thread
won't let me. In any event, Drill classes will typically start with the
constructor, then have whatever methods are appropriate for the class. The
logger creation usually happens before the constructor. I think all of your
other classes followed this format, so the one or two that didn't kind of
jumped out at me.
> Add Daffodil Format Plugin
> --------------------------
>
> Key: DRILL-8474
> URL: https://issues.apache.org/jira/browse/DRILL-8474
> Project: Apache Drill
> Issue Type: New Feature
> Affects Versions: 1.21.1
> Reporter: Charles Givre
> Priority: Major
> Fix For: 1.22.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
