[
https://issues.apache.org/jira/browse/EAGLE-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446977#comment-16446977
]
ASF GitHub Bot commented on EAGLE-1088:
---------------------------------------
GitHub user BruceKuiLiu opened a pull request:
https://github.com/apache/eagle/pull/991
EAGLE-1088: Change the inconsistent method name 'find'.
Change the method name 'find' to 'isMatched'.
The method is named "find", but the method does not find anything, just
returns a boolean-variable 'this.matched'. Thus, rename method as "isMatched"
should be more clear than "find".
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BruceKuiLiu/eagle master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/eagle/pull/991.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #991
----
commit 86e564bab1f9ec52cc653fd04a00f7893ba7a8c1
Author: Kui LIU <brucekuiliu@...>
Date: 2018-04-21T20:28:19Z
Change the method name 'find' to 'isMatched'.
----
> Inconsistent method name
> ------------------------
>
> Key: EAGLE-1088
> URL: https://issues.apache.org/jira/browse/EAGLE-1088
> Project: Eagle
> Issue Type: Improvement
> Reporter: KuiLIU
> Priority: Major
>
> The following the method is named "find", but the method does not find
> anything, just returns a boolean-variable 'this.matched'. Thus, rename method
> as "isMatched" should be more clear than "find".
> {code:java}
> public boolean find() {
> return this.matched;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
