[
https://issues.apache.org/jira/browse/EAGLE-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482042#comment-16482042
]
ASF GitHub Bot commented on EAGLE-1088:
---------------------------------------
Github user jhsenjaliya commented on the issue:
https://github.com/apache/eagle/pull/991
@BruceKuiLiu, I believe this is consistent with Java.Pattern class method
where find will return true/false based on pattern match.
I would let @yonzhang comment further on this.
Thanks for the PR though.
> Inconsistent method name
> ------------------------
>
> Key: EAGLE-1088
> URL: https://issues.apache.org/jira/browse/EAGLE-1088
> Project: Eagle
> Issue Type: Improvement
> Reporter: KuiLIU
> Priority: Major
>
> The following the method is named "find", but the method does not find
> anything, just returns a boolean-variable 'this.matched'. Thus, rename method
> as "isMatched" should be more clear than "find".
> {code:java}
> public boolean find() {
> return this.matched;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
