[
https://issues.apache.org/jira/browse/EAGLE-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15753940#comment-15753940
]
ASF GitHub Bot commented on EAGLE-843:
--------------------------------------
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/750#discussion_r92778513
--- Diff:
eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/spi/ApplicationProvider.java
---
@@ -72,7 +75,20 @@
*/
void register(ModuleRegistry registry);
- default Optional<HealthCheck> getAppHealthCheck(Config config) {
+ /**
+ * @param config application config.
+ * @return Application-specific managed health check.
+ */
+ default Optional<HealthCheck> getManagedHealthCheck(Config config) {
+ return Optional.empty();
+ }
+
+ /**
+ *
+ * @param envConfig server environment config.
+ * @return Server-level shared services.
+ */
+ default Optional<List<Service>> getSharedServices(Config envConfig) {
--- End diff --
Change#1: add `Optional<List<Service>> getSharedServices(Config envConfig)
` in `ApplicationProvider`
@qingwen220 @wujinhu
> Refactor application shared service registry framework
> ------------------------------------------------------
>
> Key: EAGLE-843
> URL: https://issues.apache.org/jira/browse/EAGLE-843
> Project: Eagle
> Issue Type: Improvement
> Reporter: Hao Chen
> Assignee: Hao Chen
>
> Refactor application shared service registry framework
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
