[
https://issues.apache.org/jira/browse/EAGLE-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15753941#comment-15753941
]
ASF GitHub Bot commented on EAGLE-843:
--------------------------------------
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/750#discussion_r92778592
--- Diff:
eagle-jpm/eagle-jpm-mr-history/src/main/java/org/apache/eagle/jpm/mr/history/MRHistoryJobApplicationProvider.java
---
@@ -35,7 +40,16 @@ public MRHistoryJobApplication getApplication() {
}
@Override
- public Optional<HealthCheck> getAppHealthCheck(Config config) {
+ public Optional<HealthCheck> getManagedHealthCheck(Config config) {
return Optional.of(new MRHistoryJobApplicationHealthCheck(config));
}
+
+ @Override
+ public Optional<List<Service>> getSharedServices(Config envConfig) {
--- End diff --
Change#2: move `MRHistoryJobDailyReporter ` registry to
`MRHistoryJobApplicationProvider` from `ServerApplication`
@qingwen220 @wujinhu
> Refactor application shared service registry framework
> ------------------------------------------------------
>
> Key: EAGLE-843
> URL: https://issues.apache.org/jira/browse/EAGLE-843
> Project: Eagle
> Issue Type: Improvement
> Reporter: Hao Chen
> Assignee: Hao Chen
>
> Refactor application shared service registry framework
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
