pandaapo commented on code in PR #4285:
URL: https://github.com/apache/eventmesh/pull/4285#discussion_r1275556304
##########
eventmesh-sdks/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/grpc/util/EventMeshCloudEventBuilder.java:
##########
@@ -248,6 +214,12 @@ private static CloudEvent
switchCloudEvent2EventMeshCloudEvent(io.cloudevents.Cl
return null;
}
+ private static void buildCloudEvent(io.cloudevents.CloudEvent message,
CloudEventBuilder cloudEventBuilder, String protocolKey, String key) {
Review Comment:
1. I think it may be better to change the method name to
`computeCloudEventIfAbsent()` according to the logic.
2. The last param is a value, not a key, so its name isn't appropriate. I
think `computeCloudEventIfAbsent(io.cloudevents.CloudEvent message,
CloudEventBuilder cloudEventBuilder, String key, String defaultValue)` may be
better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
