silentchildh commented on code in PR #4285:
URL: https://github.com/apache/eventmesh/pull/4285#discussion_r1275666471
##########
eventmesh-sdks/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/grpc/util/EventMeshCloudEventBuilder.java:
##########
@@ -248,6 +214,12 @@ private static CloudEvent
switchCloudEvent2EventMeshCloudEvent(io.cloudevents.Cl
return null;
}
+ private static void buildCloudEvent(io.cloudevents.CloudEvent message,
CloudEventBuilder cloudEventBuilder, String protocolKey, String key) {
Review Comment:
1. Yes, it's easier to read with the suffix `IfAbsent` .
2. But I think `build` might be more of a prefix fix than `compute`.After
all, we use `CloudEventbuilder` to `Build` it.
3. Maybe we could change `String protocolKey` to `String extension` and
`String key` to `String value.`.
Finally, if you have a better suggestion, I will be more than happy to see
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
