pandaapo commented on code in PR #4344:
URL: https://github.com/apache/eventmesh/pull/4344#discussion_r1295554952
##########
eventmesh-webhook/eventmesh-webhook-admin/src/main/java/org/apache/eventmesh/webhook/admin/FileWebHookConfigOperation.java:
##########
@@ -173,9 +175,11 @@ private WebHookConfig getWebHookConfigFromFile(final File
webhookConfigFile) {
}
public static boolean writeToFile(final File webhookConfigFile, final
WebHookConfig webHookConfig) {
+ // Reset latch count
+ SharedLatchHolder.latch = new CountDownLatch(1);
Review Comment:
When concurrent threads call this method, `SharedLatchHolder.latch` will be
overwritten by one of the threads. Therefore, will the lock object of the
`SharedLatchHolder.latch.await()` in the `WebhookFileListener` be uncertain?
##########
eventmesh-webhook/eventmesh-webhook-api/src/main/java/org/apache/eventmesh/webhook/api/common/SharedLatchHolder.java:
##########
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.eventmesh.webhook.api.common;
+
+import java.util.concurrent.CountDownLatch;
+
+public class SharedLatchHolder {
+ public static CountDownLatch latch = new CountDownLatch(1);
Review Comment:
A static `CountDownLatch` field can be assigned and released anywhere. It
does not seem to be an appropriate way to use `CountDownLatch`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
