pandaapo commented on code in PR #4344:
URL: https://github.com/apache/eventmesh/pull/4344#discussion_r1295780269
##########
eventmesh-webhook/eventmesh-webhook-admin/src/main/java/org/apache/eventmesh/webhook/admin/FileWebHookConfigOperation.java:
##########
@@ -173,9 +175,11 @@ private WebHookConfig getWebHookConfigFromFile(final File
webhookConfigFile) {
}
public static boolean writeToFile(final File webhookConfigFile, final
WebHookConfig webHookConfig) {
+ // Reset latch count
+ SharedLatchHolder.latch = new CountDownLatch(1);
Review Comment:
> that doesn't seem to be used concurrently.
Are you sure about that? `insertWebHookConfig` and `updateWebHookConfig` are
the same situation.
Also, regardless of the situation here, considering the next reviewing, I
don't think this is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
