pandaapo commented on code in PR #4344: URL: https://github.com/apache/eventmesh/pull/4344#discussion_r1297012782
########## eventmesh-webhook/eventmesh-webhook-api/src/main/java/org/apache/eventmesh/webhook/api/common/SharedLatchHolder.java: ########## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.eventmesh.webhook.api.common; + +import java.util.concurrent.CountDownLatch; + +public class SharedLatchHolder { + public static CountDownLatch latch = new CountDownLatch(1); Review Comment: > Don't worry too much about it. We have reviewers I think this comment is a bit worrying. It will mislead contributors to no longer pay attention to the quality of their codes, and rely more on reviewers to improve them. > and we can also add comments in similar places to make convention outweigh implementation. "Convention Over Configuration" in open-source frameworks is not in this way. It involves providing default values, default code structures, templates, and similar forms that shield the underlying complexity, simplify development, and keep flexibility. Instead of exposing code that should not be exposed and then accompanied by "prohibition of use" instructions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
