pandaapo commented on code in PR #4405: URL: https://github.com/apache/eventmesh/pull/4405#discussion_r1308168290
########## eventmesh-storage-plugin/eventmesh-storage-redis/src/main/java/org/apache/eventmesh/storage/redis/admin/RedisAdmin.java: ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.eventmesh.storage.redis.admin; + +import org.apache.eventmesh.api.admin.AbstractAdmin; +import org.apache.eventmesh.api.admin.TopicProperties; +import org.apache.eventmesh.storage.redis.client.RedissonClient; + +import java.util.List; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.stream.Collectors; + +import org.redisson.Redisson; +import org.redisson.api.RPatternTopic; +import org.redisson.api.RTopic; + +import io.cloudevents.CloudEvent; + +public class RedisAdmin extends AbstractAdmin { + + private final Redisson redisson; + + public RedisAdmin() { + super(new AtomicBoolean(false)); + redisson = RedissonClient.INSTANCE; + } + + @Override + public List<TopicProperties> getTopic() throws Exception { + RPatternTopic patternTopic = redisson.getPatternTopic("*"); + return patternTopic.getPatternNames() + .stream() + .map(s -> new TopicProperties(s, 0)) + .collect(Collectors.toList()); + } + + @Override + public void createTopic(String topicName) throws Exception { + // Just subscribe it directly, no need to create it first. Review Comment: Through your reply, I found that our understanding of the admin function is different. The admin function boundary that I understand is a bit larger. Of course, I am not sure if the community has a clear definition of this aspect. So let's take a look at the community's response to this, and if there is no response, ignore this review. --- 通过你的回复我发现我们对于admin功能的理解不同。我所理解的admin功能边界更大一些。当然我也不清楚社区对这方面有没有明确界定。所以看社区对此的反应吧，如果没有反应就忽略这条review。 ########## eventmesh-storage-plugin/eventmesh-storage-redis/src/main/java/org/apache/eventmesh/storage/redis/admin/RedisAdmin.java: ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.eventmesh.storage.redis.admin; + +import org.apache.eventmesh.api.admin.AbstractAdmin; +import org.apache.eventmesh.api.admin.TopicProperties; +import org.apache.eventmesh.storage.redis.client.RedissonClient; + +import java.util.List; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.stream.Collectors; + +import org.redisson.Redisson; +import org.redisson.api.RPatternTopic; +import org.redisson.api.RTopic; + +import io.cloudevents.CloudEvent; + +public class RedisAdmin extends AbstractAdmin { + + private final Redisson redisson; + + public RedisAdmin() { + super(new AtomicBoolean(false)); + redisson = RedissonClient.INSTANCE; + } + + @Override + public List<TopicProperties> getTopic() throws Exception { + RPatternTopic patternTopic = redisson.getPatternTopic("*"); + return patternTopic.getPatternNames() + .stream() + .map(s -> new TopicProperties(s, 0)) + .collect(Collectors.toList()); + } + + @Override + public void createTopic(String topicName) throws Exception { + // Just subscribe it directly, no need to create it first. Review Comment: Through your reply, I found that our understanding of the admin function is different. The admin function boundary that I understand is a bit larger. Of course, I am not sure if the community has a clear definition of this aspect. So let's take a look at the community's response to this, and if there is no response, ignore this review. --- 通过你的回复我发现我们对于admin功能的理解不同。我所理解的admin功能边界更大一些。当然我也不清楚社区对这方面有没有明确界定。所以看社区对此的反应吧，如果没有反应就忽略这条review。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
