pandaapo commented on code in PR #4405: URL: https://github.com/apache/eventmesh/pull/4405#discussion_r1308168402
########## eventmesh-storage-plugin/eventmesh-storage-redis/src/main/java/org/apache/eventmesh/storage/redis/admin/RedisAdmin.java: ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.eventmesh.storage.redis.admin; + +import org.apache.eventmesh.api.admin.AbstractAdmin; +import org.apache.eventmesh.api.admin.TopicProperties; +import org.apache.eventmesh.storage.redis.client.RedissonClient; + +import java.util.List; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.stream.Collectors; + +import org.redisson.Redisson; +import org.redisson.api.RPatternTopic; +import org.redisson.api.RTopic; + +import io.cloudevents.CloudEvent; + +public class RedisAdmin extends AbstractAdmin { + + private final Redisson redisson; + + public RedisAdmin() { + super(new AtomicBoolean(false)); + redisson = RedissonClient.INSTANCE; + } + + @Override + public List<TopicProperties> getTopic() throws Exception { + RPatternTopic patternTopic = redisson.getPatternTopic("*"); Review Comment: "TODO", sometimes it's just to mark problems that cannot be solved at present. For example, a preliminary simple idea is to set a configuration parameter to limit the number of matches in order to prevent potential performance issues. --- “TODO”嘛，有些时候不就是为了标记目前解决不了的问题嘛。比如一个粗糙且简单的思路：为了防止可能出现的性能问题，通过一个配置参数来限制匹配的数量。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
