pandaapo commented on code in PR #4438: URL: https://github.com/apache/eventmesh/pull/4438#discussion_r1319234589
########## eventmesh-storage-plugin/eventmesh-storage-kafka/src/main/resources/kafka-client.properties: ########## @@ -14,13 +14,21 @@ # See the License for the specific language governing permissions and # limitations under the License. # -#######################kafka-client################## -eventMesh.server.kafka.namesrvAddr=127.0.0.1:9092;127.0.0.1:9092 + +############################# EventMesh Kafka Client ############################# + +eventMesh.server.kafka.namesrvAddr=localhost:9092;localhost:9092 eventMesh.server.kafka.cluster=DefaultCluster eventMesh.server.kafka.accessKey=******** eventMesh.server.kafka.secretKey=******** +# You may see kafka.server.KafkaConfig for additional details and default values Review Comment: There are still many parameters in `KafkaConfig` that are not supported by eventmesh, is it appropriate to write comment this way? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
