Pil0tXia commented on code in PR #4438: URL: https://github.com/apache/eventmesh/pull/4438#discussion_r1319272768
########## eventmesh-storage-plugin/eventmesh-storage-kafka/src/main/resources/kafka-client.properties: ########## @@ -14,13 +14,21 @@ # See the License for the specific language governing permissions and # limitations under the License. # -#######################kafka-client################## -eventMesh.server.kafka.namesrvAddr=127.0.0.1:9092;127.0.0.1:9092 + +############################# EventMesh Kafka Client ############################# + +eventMesh.server.kafka.namesrvAddr=localhost:9092;localhost:9092 eventMesh.server.kafka.cluster=DefaultCluster eventMesh.server.kafka.accessKey=******** eventMesh.server.kafka.secretKey=******** +# You may see kafka.server.KafkaConfig for additional details and default values Review Comment:  This comment is written by someone else and it comes from Kafka: https://github.com/apache/kafka/blob/54ab5b29e47fd3f399e0575df2f490a33f12804b/config/server.properties#L17-L18 I think the reason he wrote it that way is that this config file comes from kafka, and there are a lot of configuration items that are specific to kafka, not eventmesh, so you need to refer to the handling of configurations in kafka to understand the configurations further. I have moved this comment to a more suitable place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
