yanrongzhen commented on code in PR #4447:
URL: https://github.com/apache/eventmesh/pull/4447#discussion_r1332401959
##########
eventmesh-connectors/eventmesh-connector-rocketmq/src/main/java/org/apache/eventmesh/connector/rocketmq/source/connector/RocketMQSourceConnector.java:
##########
@@ -273,7 +273,7 @@ private long removeMessage(MessageQueue mq, long offset) {
private void execScheduleTask() {
commitOffsetScheduleService.scheduleAtFixedRate(this::commitOffsetSchedule,
sourceConfig.connectorConfig.getCommitOffsetIntervalMs(),
- sourceConfig.connectorConfig.getCommitOffsetIntervalMs(),
TimeUnit.MILLISECONDS);
+ sourceConfig.connectorConfig.getCommitOffsetIntervalMs(),
TimeUnit.MILLISECONDS);
}
Review Comment:
This is because I excluded this file from the spotless conversion list
first, and fixed the indentation issue in a later commit.
I'll fix this in a new round of commits.
##########
eventmesh-connectors/eventmesh-connector-rocketmq/src/main/java/org/apache/eventmesh/connector/rocketmq/source/connector/RocketMQSourceConnector.java:
##########
@@ -220,7 +220,7 @@ public List<ConnectRecord> poll() {
byte[] body = messageExt.getBody();
String bodyStr = new String(body, StandardCharsets.UTF_8);
RecordPartition recordPartition =
convertToRecordPartition(messageExt.getTopic(),
- messageExt.getBrokerName(), messageExt.getQueueId());
+ messageExt.getBrokerName(), messageExt.getQueueId());
RecordOffset recordOffset =
convertToRecordOffset(messageExt.getQueueOffset());
Review Comment:
Yes, this is because I excluded this file from the spotless conversion list
first, and fixed the indentation issue in a later commit.
I'll fix this in a new round of commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
