yanrongzhen commented on code in PR #4447:
URL: https://github.com/apache/eventmesh/pull/4447#discussion_r1332414649
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/ThreadPoolFactory.java:
##########
@@ -35,26 +35,25 @@ public static ThreadPoolExecutor
createThreadPoolExecutor(int core, int max, fin
}
public static ThreadPoolExecutor createThreadPoolExecutor(int core, int
max, final String threadName,
- final boolean isDaemon) {
+ final boolean
isDaemon) {
return createThreadPoolExecutor(core, max, new
LinkedBlockingQueue<>(1000), threadName, isDaemon);
}
public static ThreadPoolExecutor createThreadPoolExecutor(int core, int
max, BlockingQueue<Runnable> blockingQueue,
- final String threadName, final boolean isDaemon) {
+ final String
threadName, final boolean isDaemon) {
return new ThreadPoolExecutor(core, max, 10 * 1000,
TimeUnit.MILLISECONDS, blockingQueue,
Review Comment:
I agree with, I don't think it is necessary to align according to the first
parameter of the method first, and then turn this alignment strategy on when
the community thinks it needs to be aligned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
