pandaapo commented on code in PR #4484:
URL: https://github.com/apache/eventmesh/pull/4484#discussion_r1358172038
##########
eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/util/EventMeshUtilTest.java:
##########
@@ -167,13 +167,10 @@ public void testCloneObject() throws IOException,
ClassNotFoundException {
@Test
public void testPrintState() {
- try {
- ScheduledExecutorService serviceRebalanceScheduler =
ThreadPoolFactory
- .createScheduledExecutor(5, new
EventMeshThreadFactory("proxy-rebalance-sch", true));
- EventMeshUtil.printState((ThreadPoolExecutor)
serviceRebalanceScheduler);
- } catch (Exception e) {
- Assertions.fail(e.getMessage());
- }
+ // Must not throw an exception
+ ScheduledExecutorService serviceRebalanceScheduler = ThreadPoolFactory
+ .createScheduledExecutor(5, new
EventMeshThreadFactory("proxy-rebalance-sch", true));
+ EventMeshUtil.printState((ThreadPoolExecutor)
serviceRebalanceScheduler);
Review Comment:
The same situation as above.
There are also similar situations with other codes that you have modified.
You can check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
